Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire - Noor #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(n log n)
# Space Complexity: O(n)
def heapsort(list)
Comment on lines +4 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

heap = MinHeap.new
result = []

list.each {|element| heap.add(element)}

until heap.empty?
result << heap.remove
end

return result
end
67 changes: 51 additions & 16 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,29 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def add(key, value = key)
Comment on lines +17 to 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)
heap_up(@store.length - 1) # move the new added node up (swap with parent only)
end

#This method removes and returns the smallest keyed value from the heap.
# This method removes and returns an element from the heap
#This method removes and returns the smallest keyed value from the heap.
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
def remove()
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def remove() # removing the first
return nil if @store.empty?

swap(0, @store.length - 1) # swap the last element with the root
removed = @store.pop

heap_down(0) unless @store.empty?

removed.value

end


Expand All @@ -44,28 +55,52 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +58 to 60

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
@store.empty?
end

private

# down to up
# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# moves it up the heap, if it is less than its parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
def heap_up(index)

# Time complexity: O(logn)
# Space complexity: O(1)
def heap_up(index) # move the current index up to the parent and do the needed changes
parent = (index - 1 ) / 2

if index == 0
return
elsif @store[index].key < @store[parent].key
swap(parent,index)
heap_up(parent) # keep pushing the parent up till it's < @store[index].key
end
end

# up to down
# this method takes the parent(root) and 'heap it down' to it's right place
# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done!

raise NotImplementedError, "Method not implemented yet..."
left_child = (index * 2) + 1 # odd is left child
right_child = (index * 2) + 2 # even is right child

if left_child >= @store.length # reached the limit
return
# if right child < parent AND
# if right child < left
elsif @store[right_child] && @store[right_child].key < @store[left_child].key && @store[right_child].key < @store[index].key
swap(right_child, index)
heap_down(right_child)
# if left child < parent
elsif @store[left_child].key < @store[index].key
swap(left_child, index)
heap_down(left_child)
end
end

# If you want a swap method... you're welcome
Expand Down
2 changes: 1 addition & 1 deletion test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []
Expand Down