forked from AdaGold/heaps
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire - Noor #27
Open
hn4ever
wants to merge
2
commits into
Ada-C14:master
Choose a base branch
from
hn4ever:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fire - Noor #27
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,17 @@ | ||
|
||
|
||
# This method uses a heap to sort an array. | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
def heap_sort(list) | ||
raise NotImplementedError, "Method not implemented yet..." | ||
# Time Complexity: O(n log n) | ||
# Space Complexity: O(n) | ||
def heapsort(list) | ||
heap = MinHeap.new | ||
result = [] | ||
|
||
list.each {|element| heap.add(element)} | ||
|
||
until heap.empty? | ||
result << heap.remove | ||
end | ||
|
||
return result | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,18 +14,29 @@ def initialize | |
end | ||
|
||
# This method adds a HeapNode instance to the heap | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(log n) | ||
# Space Complexity: O(log n) | ||
def add(key, value = key) | ||
Comment on lines
+17
to
19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
raise NotImplementedError, "Method not implemented yet..." | ||
@store << HeapNode.new(key, value) | ||
heap_up(@store.length - 1) # move the new added node up (swap with parent only) | ||
end | ||
|
||
#This method removes and returns the smallest keyed value from the heap. | ||
# This method removes and returns an element from the heap | ||
#This method removes and returns the smallest keyed value from the heap. | ||
# maintaining the heap structure | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
def remove() | ||
raise NotImplementedError, "Method not implemented yet..." | ||
# Time Complexity: O(log n) | ||
# Space Complexity: O(log n) | ||
def remove() # removing the first | ||
return nil if @store.empty? | ||
|
||
swap(0, @store.length - 1) # swap the last element with the root | ||
removed = @store.pop | ||
|
||
heap_down(0) unless @store.empty? | ||
|
||
removed.value | ||
|
||
end | ||
|
||
|
||
|
@@ -44,28 +55,52 @@ def to_s | |
end | ||
|
||
# This method returns true if the heap is empty | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
# Time complexity: O(1) | ||
# Space complexity: O(1) | ||
def empty? | ||
Comment on lines
+58
to
60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
raise NotImplementedError, "Method not implemented yet..." | ||
@store.empty? | ||
end | ||
|
||
private | ||
|
||
# down to up | ||
# This helper method takes an index and | ||
# moves it up the heap, if it is less than it's parent node. | ||
# moves it up the heap, if it is less than its parent node. | ||
# It could be **very** helpful for the add method. | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
def heap_up(index) | ||
|
||
# Time complexity: O(logn) | ||
# Space complexity: O(1) | ||
def heap_up(index) # move the current index up to the parent and do the needed changes | ||
parent = (index - 1 ) / 2 | ||
|
||
if index == 0 | ||
return | ||
elsif @store[index].key < @store[parent].key | ||
swap(parent,index) | ||
heap_up(parent) # keep pushing the parent up till it's < @store[index].key | ||
end | ||
end | ||
|
||
# up to down | ||
# this method takes the parent(root) and 'heap it down' to it's right place | ||
# This helper method takes an index and | ||
# moves it up the heap if it's smaller | ||
# than it's parent node. | ||
def heap_down(index) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Nicely done! |
||
raise NotImplementedError, "Method not implemented yet..." | ||
left_child = (index * 2) + 1 # odd is left child | ||
right_child = (index * 2) + 2 # even is right child | ||
|
||
if left_child >= @store.length # reached the limit | ||
return | ||
# if right child < parent AND | ||
# if right child < left | ||
elsif @store[right_child] && @store[right_child].key < @store[left_child].key && @store[right_child].key < @store[index].key | ||
swap(right_child, index) | ||
heap_down(right_child) | ||
# if left child < parent | ||
elsif @store[left_child].key < @store[index].key | ||
swap(left_child, index) | ||
heap_down(left_child) | ||
end | ||
end | ||
|
||
# If you want a swap method... you're welcome | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍