Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRE - ALICE D #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(n log n)
# Space Complexity: O(n)
def heapsort(list)
Comment on lines +4 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

heapsorted_array = []
return heapsorted_array if list.empty?

heap = MinHeap.new()

list.each do |item|
heap.add(item)
end

list.length.times do
removed = heap.remove()
heapsorted_array << removed
end

return heapsorted_array
Comment on lines +16 to +21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Suggested change
list.length.times do
removed = heap.remove()
heapsorted_array << removed
end
return heapsorted_array
list.length.times do
removed = heap.remove()
heapsorted_array << removed
end
return heapsorted_array



end
72 changes: 54 additions & 18 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,26 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(1)
def add(key, value = key)
Comment on lines +17 to 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space complexity is O(log n) because of heap_up's recursion.

raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)

heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(1)
def remove()
Comment on lines +27 to 29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, but the space complexity is O(log n) due to heapdown's recursion

raise NotImplementedError, "Method not implemented yet..."
return nil if @store.empty?

swap(0, @store.length - 1)
result = @store.pop.value

heap_down(0) unless @store.empty?
return result
end


Expand All @@ -44,31 +52,59 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +55 to 57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return true if @store.length == 0
return false if @store.length > 0
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# The heap up method takes an index and
# moves it up the heap, if it is less than its parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n)
# Space complexity: O(log n)
def heap_up(index)
Comment on lines +67 to 69

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return @store if index == 0

parent_index = (index - 1)/2
return @store if @store[index].key >= @store[parent_index].key

if @store[index].key < @store[parent_index].key
swap(parent_index,index)
heap_up(parent_index)
end

end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
# The heap down method takes an index and
# moves it DOWN the heap if it's larger
# than its parent node
# Time complexity: O(log n)
# Space complexity: O(log n)

def heap_down(index)
Comment on lines +85 to 88

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done

raise NotImplementedError, "Method not implemented yet..."
return @store if index == @store.length - 1

left_child_index = 2 * index + 1
right_child_index = 2 * index + 2

if (left_child_index < @store.length) && (@store[index].key > @store[left_child_index].key)
swap(left_child_index, index)
heap_down(index)
end

if (right_child_index < @store.length) && (@store[index].key > @store[right_child_index].key)
swap(right_child_index, index)
heap_down(index)
end

end

# If you want a swap method... you're welcome
# If you want a swap method... you're welcome;
# thank you :)
def swap(index_1, index_2)
temp = @store[index_1]
@store[index_1] = @store[index_2]
Expand Down
2 changes: 1 addition & 1 deletion test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []
Expand Down