Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire - Roshni #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fire - Roshni #18

wants to merge 3 commits into from

Conversation

roshni-patel
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Roshni, you hit the learning goals here. Well done.

Comment on lines +15 to 17
# Time Complexity: O(n) to iterate through the entire nums array
# Space Complexity: O(1) given that the space required for max_so_far and max_ending_here do not change with the size of nums
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Perfect

Comment on lines +1 to +3
# Time complexity: O(n) as the number of iterations required increases as the number grows
# Space Complexity: O(n) as the size of the solutions array grows as the size of the number grows
def newman_conway(num)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants