Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : configurable autostart,autostart watchers and port #30

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Dec 6, 2024

Important

Add configurable autostart, module autostart, and port settings using a new Config struct in lib.rs.

  • Configuration:
    • Introduce Config struct in lib.rs for managing autostart_modules, autolaunch, autostart_minimized, and port.
    • Implement get_config() and get_config_path() in lib.rs to handle configuration file reading and writing.
  • Autostart Management:
    • Use Config to enable/disable autostart in run() in lib.rs.
    • Update start_manager() in manager.rs to use Config for autostart modules.
  • Port Configuration:
    • Use Config to set server port in run() in lib.rs and start_module_thread() in manager.rs.
  • Dependencies:
    • Add directories and update toml version in Cargo.toml.
    • Update Cargo.lock with new and updated dependencies.

This description was created by Ellipsis for cb7e1a2. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cb7e1a2 in 2 minutes and 3 seconds

More details
  • Looked at 466 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. src-tauri/src/lib.rs:35
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. src-tauri/src/lib.rs:39
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Marked as duplicate.
3. src-tauri/src/lib.rs:140
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Marked as duplicate.
4. src-tauri/src/lib.rs:201
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Marked as duplicate.
5. src-tauri/src/manager.rs:200
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Marked as duplicate.
6. src-tauri/src/manager.rs:262
  • Draft comment:
    Using unwrap can lead to panics if the expected value is not present. Consider using expect with a meaningful error message or handling the error gracefully. This is also applicable in other parts of the code where unwrap is used.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_PBFEiQdSkwS9SZ2y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo merged commit 814406e into ActivityWatch:master Dec 6, 2024
5 checks passed
@0xbrayo 0xbrayo mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant