Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement single instance #22

Closed
wants to merge 1 commit into from

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Nov 27, 2024

Important

Implement single-instance feature using tauri-plugin-single-instance to ensure only one app instance runs.

  • Behavior:
    • Implement single-instance feature using tauri-plugin-single-instance in src-tauri/src/lib.rs.
    • Logs a message and quits if another instance is detected.
  • Dependencies:
    • Add tauri-plugin-single-instance to Cargo.toml and Cargo.lock.
  • Documentation:
    • Update README.md to mark single-instance feature as complete.

This description was created by Ellipsis for b42b85c. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b42b85c in 25 seconds

More details
  • Looked at 673 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src-tauri/src/lib.rs:46
  • Draft comment:
    Using unwrap() can lead to panics if the value is not present. Consider handling the error gracefully or using expect() with a meaningful message.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of unwrap() can lead to panics if the value is not present. It's better to handle the error gracefully.

Workflow ID: wflow_UFr0rcsSc0NwRV57


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo
Copy link
Member Author

0xbrayo commented Nov 27, 2024

closes #15

@0xbrayo 0xbrayo closed this Nov 30, 2024
@0xbrayo 0xbrayo deleted the single-instance branch January 8, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant