[rqd] Check if uid is valid before launching frame #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the frame uid is outside of linux defined UID_MAX and UID_MIN fallback to the uid of the daemon user. Read https://www.man7.org/linux/man-pages/man5/login.defs.5.html for more information about uid limits. At this time, limits are hardcoded on rqconstants as the linux default values, which sounds reasonable as this default config limit is rarely modified.
DiegoTavares
requested review from
bcipriano,
ramonfigueiredo and
lithorus
as code owners
ramonfigueiredo
approved these changes
Feb 12, 2025
Co-authored-by: Ramon Figueiredo <[email protected]> Signed-off-by: Diego Tavares <[email protected]>
DiegoTavares
merged commit aba67ce
into
AcademySoftwareFoundation:master
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the frame uid is outside of linux defined UID_MAX and UID_MIN fallback to the uid of the daemon user. Read https://www.man7.org/linux/man-pages/man5/login.defs.5.html for more information about uid limits. At this time, limits are hardcoded on rqconstants as the linux default values, which sounds reasonable as this default config limit is rarely modified.