Add pybind11 wrappings for Imath::Frustum #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
|
good @cary-ilm |
|
CI failures are unrelated, and should be fixed by #455. Thanks! |
cary-ilm
merged commit 2e78172
into
AcademySoftwareFoundation:main
19 of 31 checks passed
|
@TodicaIonut, looks like I merged too soon, the code doesn't compile. On line line 19 of
This slipped through because the previous state the CI checks failed to actually build with Could you kindly submit a separate PR to resolve this? |
cary-ilm
reviewed
Dec 17, 2024
| pybind11::class_<T> c(m, name); | ||
| c.def(pybind11::init<>(), "Uninitialized by default") | ||
| .def(pybind11::init<T>(), pybind11::arg("frustum"), "Copy constructor") | ||
| .def(pybind11::init<S>(), pybind11::arg("nearPlane"), pybind11::arg("farPlane"), pybind11::arg("fovx"), pybind11::arg("aspect"), "Initialize with basic frustum properties") |
| .def_readwrite("fovx", &T::fovx, "The field of view in x direction") | ||
| .def_readwrite("aspect", &T::aspect, "The aspect ratio") | ||
|
|
||
| .def("set", pybind11::overload_cast<S, S, S, S>(&T::set), pybind11::arg("nearPlane"), pybind11::arg("farPlane"), pybind11::arg("fovx"), pybind11::arg("aspect"), "Set frustum properties") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.