This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
feat: Add session key module validator #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeexcoin
force-pushed
the
session-key
branch
from
e9e7a71 to
2510710
Compare
coffeexcoin
changed the title
…ter validation in session key validator
cygaar
approved these changes
Dec 16, 2024
| * @param smartAccount The smart account to check | ||
| * @return true if validator is registered for the account, false otherwise | ||
| */ | ||
| function isInited(address smartAccount) external view returns (bool) { |
There was a problem hiding this comment.
Clave modules use a custom IInitable that uses this method
// SPDX-License-Identifier: GPL-3.0
pragma solidity ^0.8.17;
interface IInitable {
event Inited(address indexed account);
event Disabled(address indexed account);
function init(bytes calldata initData) external;
function disable() external;
function isInited(address account) external view returns (bool);
}| @@ -89,6 +89,9 @@ const config: HardhatUserConfig = { | |||
| }, | |||
| solidity: { | |||
| version: '0.8.26', | |||
| settings: { | |||
| evmVersion: 'cancun', | |||
There was a problem hiding this comment.
I noticed most of our contracts use ^0.8.24, do we want to bump those versions to 0.8.26 to match our compiler version?
There was a problem hiding this comment.
Might clean this up in a separate PR. I am going to lock zksolc to 1.5.6 right now to prevent any sort of verification issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.