Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#542 Add databricks driver processing in SqlGeneratorLoader and provide databricks dialect using #543

Merged
merged 1 commit into from
Jan 16, 2025
Merged

#542 Add databricks driver processing in SqlGeneratorLoader and provide databricks dialect using #543

merged 1 commit into from
Jan 16, 2025

Conversation

ValeriiKhalimendik
Copy link
Collaborator

…iver processing

@github-actions GitHub Actions
Copy link

Unit Test Coverage

Overall Project 84.42% -0.07% 🍏
Files changed 89.2% 🍏

Module Coverage
pramen:core Jacoco Report 85.27% -0.08% 🍏
Files
Module File Coverage
pramen:core Jacoco Report SqlGeneratorDatabricks.scala 96.38% -3.62% 🍏
SqlGeneratorLoader.scala 93.13% 🍏
DatabricksDialect.scala 25.93% -77.78% ❌

yruslan
yruslan approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@yruslan yruslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution!

@ValeriiKhalimendik ValeriiKhalimendik merged commit 065561b into main Jan 16, 2025
8 checks passed
@ValeriiKhalimendik ValeriiKhalimendik deleted the feature/542-add-databricks-driver-processing branch January 16, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yruslan yruslan yruslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValeriiKhalimendik @yruslan