Update versions of Scala, Spark and sbt for builds and CI/CD. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yruslan
force-pushed
the
feature/382-update-scala-spark-versions
branch
from
1f7a9c9 to
28fd46b
Compare
yruslan
force-pushed
the
feature/382-update-scala-spark-versions
branch
from
28fd46b to
8d810c0
Compare
Unit Test Coverage
|
yruslan
force-pushed
the
feature/382-update-scala-spark-versions
branch
3 times, most recently
from
792bd4a to
e4cde8b
Compare
yruslan
force-pushed
the
feature/382-update-scala-spark-versions
branch
from
e4cde8b to
e58f036
Compare
Zejnilovic
reviewed
Mar 22, 2024
| @@ -18,26 +18,30 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| scala: [2.11.12, 2.12.18, 2.13.12] | |||
| spark: [2.4.8, 3.2.4, 3.3.3, 3.4.1] | |||
| scala: [2.11.12, 2.12.19, 2.13.13] | |||
There was a problem hiding this comment.
Wouldn't an include syntax be better than exclude in the case of Scala 2.11?
There was a problem hiding this comment.
I'm going to check and compare, thanks!
Zejnilovic
approved these changes
Mar 22, 2024
cerveada
reviewed
Mar 22, 2024
pramen/project/Versions.scala
Outdated
| case version if version.startsWith("2.4.") => "5.1.1" | ||
| case version if version.startsWith("3.0.") => "5.1.1" | ||
| case version if version.startsWith("3.1.") => "5.1.1" | ||
| case version if version.startsWith("3.2.") => "6.1.1" |
There was a problem hiding this comment.
6.1.1is really only for Spark3.2.0specifically- For Spark
3.2.x (x > 0)the latest Abris version should be used
All this mess is caused by Spark breaking a compatibility: AbsaOSS/ABRiS#280
cerveada
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382
Updates versions to latest patches, and replaces obsolete
setup-scalaplugin so that JDK is latest, not old like this:With the change:
