Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#284 Fix lock/semaphore/channel resource release on fatal errors. #285

Merged
merged 1 commit into from
Nov 8, 2023
Merged

#284 Fix lock/semaphore/channel resource release on fatal errors. #285

merged 1 commit into from
Nov 8, 2023

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Nov 8, 2023 •
edited
Loading

Closes #284

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Unit Test Coverage

File Coverage [83.45%] 🍏
TaskRunnerMultithreaded.scala 100% 🍏
TransformationJob.scala 95.56% 🍏
ConcurrentJobRunnerImpl.scala 95.22% 🍏
SinkJob.scala 93.4% 🍏
PythonTransformationJob.scala 91.8% 🍏
TaskRunnerBase.scala 80.93% 🍏
IngestionJob.scala 77.75% 🍏
JobBase.scala 76.12% 🍏
Emoji.scala 74.7% ❌
Total Project Coverage 82.49% 🍏

@yruslan yruslan marked this pull request as ready for review November 8, 2023 12:56
@yruslan yruslan requested a review from jirifilip as a code owner November 8, 2023 12:56
@yruslan yruslan merged commit 76a5fe6 into main Nov 8, 2023
9 checks passed
@yruslan yruslan deleted the bugfix/284-handling-of-fatal-errors branch November 8, 2023 15:23
@yruslan yruslan mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirifilip jirifilip Awaiting requested review from jirifilip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multithreaded parallel pipeline can deadlock if fatal error has occured
1 participant
@yruslan