Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/initial solution #2

Merged
merged 45 commits into from
Jun 11, 2024
Merged

Feature/initial solution #2

merged 45 commits into from
Jun 11, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented May 23, 2024

  • Initial implementation of the solution.

Now, we can extend our IT test approach with this GH action, which can check our repositories for forgotten test files not following the test file naming convention.

Closes #1

@miroslavpojer miroslavpojer self-assigned this May 23, 2024
@miroslavpojer miroslavpojer added the work in progress Work on this item is not yet finished (mainly intended for PRs) label May 23, 2024
@miroslavpojer
Copy link
Collaborator Author

After discussing with @lsulak, I have migrated this solution to a 100% GH Action composite solution to remove dependency on Javascript and keep the solution 100% Python-based.

@miroslavpojer
Copy link
Collaborator Author

Release Notes

  • Designed and implemented GH Composite Action.

@miroslavpojer miroslavpojer requested a review from Zejnilovic June 3, 2024 07:11
README.md Outdated Show resolved Hide resolved
@miroslavpojer miroslavpojer requested a review from Zejnilovic June 3, 2024 13:16
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@miroslavpojer miroslavpojer requested a review from Zejnilovic June 4, 2024 07:33
- Removed support for case sensitivity and suffix vs contains after introducing glob.
- Rename include_directories to paths.
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
- Fix forgotten rename location.
- Renamed suffix to name_patterns.
- Adding lower function to be more flexible for inputs.
- Fixed problem with shared attribute names.
@miroslavpojer miroslavpojer requested a review from Zejnilovic June 11, 2024 06:49
README.md Outdated Show resolved Hide resolved
@miroslavpojer miroslavpojer requested a review from Zejnilovic June 11, 2024 07:43
@miroslavpojer miroslavpojer merged commit 6016e61 into master Jun 11, 2024
2 checks passed
@miroslavpojer miroslavpojer deleted the feature/initial-solution branch June 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create solution PoC
2 participants