Feature/57,58 function commons #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dk1844
requested review from
benedeki,
jakipatryk,
lsulak and
Zejnilovic
as code owners
JaCoCo code coverage report - scala 2.11.12
|
JaCoCo code coverage report - scala 2.12.17
|
lsulak
reviewed
Oct 11, 2023
lsulak
reviewed
Oct 11, 2023
jakipatryk
reviewed
Oct 11, 2023
| */ | ||
| package za.co.absa.ultet.model.function | ||
|
|
||
| case class FunctionGrant() extends FunctionEntry () { |
There was a problem hiding this comment.
Suggested change
| case class FunctionGrant() extends FunctionEntry () { | |
| case class FunctionGrant() extends FunctionEntry { |
lsulak
reviewed
Oct 11, 2023
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| package za.co.absa.ultet.dbitems | |||
|
|
|||
| import za.co.absa.ultet.sqlentry.SQLEntry | |||
| import za.co.absa.ultet.model.SQLEntry | |||
|
|
|||
| trait DBItem { | |||
| def sqlEntry: SQLEntry | |||
There was a problem hiding this comment.
this will be a seq, can you change it?
lsulak
approved these changes
Oct 11, 2023
jakipatryk
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakipatryk @benedeki