Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First suggestion on the structure of input files #55

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

benedeki
Copy link
Contributor

No description provided.

@benedeki benedeki self-assigned this Oct 10, 2023
@github-actions
Copy link

JaCoCo code coverage report - scala 2.11.12

There is no coverage information present for the Files changed

Total Project Coverage 48.81% 🍏

@github-actions
Copy link

JaCoCo code coverage report - scala 2.12.17

There is no coverage information present for the Files changed

Total Project Coverage 48.96% 🍏

primary_key:
pk_my_table:
columns: [id_key_field]
indexes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps an option to specify type of index can be needed..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, index properties can be added. If missing the PG default is to be used. (Same for fields actually)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

description: This is an example table
primary_db: example_db
owner: some_owner_user
columns:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what about constraints? Like the UNIQUE at least?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later phase. For now, it will be just unique index (hope we manage indexes)

Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start, I provided some further ideas for discussion

Copy link
Contributor

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review

owner: some_owner_user
columns:
- id_key_field:
type: bigint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does you expect to have comment on this line? Maybe they would be usefull.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on what? The field comment is in the description field.

columns: [id_key_field]
indexes:
idx_some_name:
columns: [some_name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreign keys will be supported too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the start no. FK can be omitted when using functions for data entry.

@benedeki benedeki merged commit 70714b8 into ultet Oct 11, 2023
5 checks passed
@benedeki benedeki deleted the feature/ultet-example-files branch October 11, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants