-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First suggestion on the structure of input files #55
Conversation
JaCoCo code coverage report - scala 2.11.12
|
JaCoCo code coverage report - scala 2.12.17
|
primary_key: | ||
pk_my_table: | ||
columns: [id_key_field] | ||
indexes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps an option to specify type of index can be needed..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, index properties can be added. If missing the PG default is to be used. (Same for fields actually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
description: This is an example table | ||
primary_db: example_db | ||
owner: some_owner_user | ||
columns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what about constraints? Like the UNIQUE at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later phase. For now, it will be just unique index (hope we manage indexes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good start, I provided some further ideas for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- code review
owner: some_owner_user | ||
columns: | ||
- id_key_field: | ||
type: bigint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does you expect to have comment on this line? Maybe they would be usefull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on what? The field comment is in the description field.
columns: [id_key_field] | ||
indexes: | ||
idx_some_name: | ||
columns: [some_name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Foreign keys will be supported too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the start no. FK can be omitted when using functions for data entry.
No description provided.