-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling unquoted codecs #6
base: master
Are you sure you want to change the base?
Conversation
This looks good to me, but I hope we could get unit tests added for any new additions. Though we might not be able to easily test mdls consistently, I think we could at least export the Would you mind adding a unit test--maybe Mocha--for your addition? With some testing framework in place, we can then sanity check with any new modifications (and also try to eventually add tests to cover other supported parsing scenarios). |
I'm going to second the call for tests please.e |
@avimak just checking in, do you intend to add tests? |
sorry, can't find the time |
The "Now handling parenthesis in file names" commit only selectively escapes file names. Instead of escaping the file name it should just be wrapped in quotes, eg:
I have this adjusted on my fork at https://github.com/pdenya/node-mdls. I merged the rest of the changes from this PR and I'm also not planning to add tests so didn't think it was worth submitting another PR against. |
sometimes
mdls
returns unquoted codec names, i.e.("H.264",AAC)
, so instead of failing the parsing process completely, we better try looking for Alphabet characters in it and return them as value in case we managed to find at least one non-digit/valid Alphabet char.