makefile integration target to submit all the integration payloads #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhkennedy
added
the
bumpless
jhkennedy
force-pushed
the
make-integration
branch
from
1b7b57b to
1e86491
Compare
jtherrmann
reviewed
Mar 26, 2024
Makefile
Outdated
| @@ -12,6 +13,10 @@ test_file ?= 'tests/' | |||
| test: | |||
| pytest $(test_file) | |||
|
|
|||
| integration: | |||
| export AWS_PAGER='' && \ | |||
| $(foreach file, $(wildcard tests/integration/*.json), echo "aws sns publish --profile saml-pub --topic-arn ${TEST_TOPIC_ARN} --message file://${file} --output json";) | |||
There was a problem hiding this comment.
Probably hitting the limits of my bash knowledge, but why is there an echo before the aws sns command?
There was a problem hiding this comment.
because I was testing it without running it and accidentelly committed the echo 🤣
There was a problem hiding this comment.
I should just be using the --just-print or -n make options:
https://web.mit.edu/gnu/doc/html/make_5.html
There was a problem hiding this comment.
Nice, did not know about those options.
jtherrmann
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.