upgrade to mypy action v0.15.0 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -11,4 +11,4 @@ | |||
| uses: ASFHyP3/actions/.github/workflows/[email protected] | |||
|
|
|||
| call-mypy-workflow: | |||
| uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.14.0 | |||
| uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.15.0 | |||
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
williamh890
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were enabling
explicit_package_basesto solve the duplicateconftest.pyerror, but then when we remove the--ignore-missing-importsoption by upgrading the mypy action, it turns out that mypy can't find any of theasf_tools.*imports. When we removeexplicit_package_basesand instead excludeconftest.pyfiles, we're left with 27 errors to address. This seems reasonable, though I wonder if there's a better way that doesn't exclude theconftest.pyfiles.Edit: The solution is to add a
tests/__init__.pyfile, which is also recommended by pytest.