osmium-tool dependency missing for asf-tools PyPI distribution bug #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPlayer3
added
bug
jhkennedy
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Looks good so far.
I'd still prefer to see some brief discussion of the watermasking part of asf_tools here:
https://github.com/ASFHyP3/asf-tools/tree/develop/src/asf_tools
which can mostly be a link to src/asf_tools/watermasking/README.MD and a note like:
The
asf_tools.watermaskingsub-package requiresosmium-tool; see README.MD .
And admittedly it's a nitpick, but I'd like to see README.MD -> README.md to match or convention everywhere else.
jhkennedy
approved these changes
Mar 1, 2024
jhkennedy
removed
the
bumpless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.