-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: MPLNET Discovery Module #855
Conversation
@jrobrien91 will try to get to reviewing soon. In reviews and meetings all day/week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be working! Just looking ahead, I tried to read the file in with with just xarray and it is problematic so definitely not a straightforward way.
xarray.core.variable.MissingDimensionsError: 'altitude' has more than 1-dimension and the same name as one of its dimensions ('time', 'altitude'). xarray disallows such variables because they conflict with the coordinates used to label dimensions.
@AdamTheisen So far I have a fix for Altitude and am able to read these into xarray, but these are some funky files. Over half the dimensions do not have assigned coordinates which is breaking |
@jrobrien91 awesome! I would defer to you if you want to wait to have it in this PR or another one. This looks good to move forward with on my end but will defer to @zssherman I'm not sure if it would be helpful but the ARM MMCR files are problematic with xarray as well and we had to do some base NetCDF workarounds. You can check out the code at the following link if that helps: https://github.com/ARM-DOE/ACT/blob/main/act/io/arm.py#L817 |
@AdamTheisen I would be fine with merging this in! We can then work on updating the example and having the actual IO separately. |
Notes:
read_arm_netcdf
I/O module. This is primarily due to the altitude dimension not containing a corresponding 1D coordinate within the files.nasa.py
as I anticipate eventually including discovery modules for NASA AERONET and PANDORA APIs as well.