-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
닉네임뷰 버그 해결 및 회원가입, 탈퇴 오류 에러 핸들링 #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존은 회원탈퇴 후 재가입했으나, 유저 이탈을 고려해 재인증 후 바로 가입 하도록 수정
있는 경우는 현재 로그인 중으로 재인증에 해당한다. 재인증일 때 현재 로그인 한 계정의 이메일과 재인증한 계정의 이메일이 다르면 인증을 멈춘다.
기존: 재인증 뷰가 내려가고 "포스티 시작하기" 버튼을 눌러야 닉네임 확정 alert가 나타남 수정: 재인증이 성공하여 계정 생성에 필요한 AuthManager의 authDataResult 값이 nil이 아닌 것이 확인되면 onChange로 감지하여 닉네임 확정 alert를 띄워준다. 그 동안 LoadingView대신 버튼이 비활성화 되며 버튼 텍스트 대신 ProgressView가 나타난다. 텍스트 필드 입력도 비활성화 된다.
trafico-bot
bot
added
👀 리뷰 요청
PR이 아직 리뷰되지 않고 있어요
🎄 현진
Pull Request Reviews assigned to GitHub User: hjsupernova
🍖 주원
Pull Request Reviews assigned to GitHub User: lm-loki
labels
Feb 22, 2024
This was
linked to
issues
Feb 22, 2024
hjsupernova
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
trafico-bot
bot
added
👍 Merge 진행
PR 승인이 완료되어 merge할 수 있어요
and removed
👀 리뷰 요청
PR이 아직 리뷰되지 않고 있어요
🎄 현진
Pull Request Reviews assigned to GitHub User: hjsupernova
labels
Feb 22, 2024
trafico-bot
bot
added
👏 Merge 완료
PR이 성공적으로 merge되었어요
and removed
👍 Merge 진행
PR 승인이 완료되어 merge할 수 있어요
labels
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍖 주원
Pull Request Reviews assigned to GitHub User: lm-loki
🐛 Bug
버그를 발견했어요
✨ Feat
새로운 기능을 구현했어요
👏 Merge 완료
PR이 성공적으로 merge되었어요
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
변경 사항
공유사항(배운 것, 참고하면 좋을 것)
스크린샷
전달사항