CI: WarpX on development
#4110
Merged
CI: WarpX on development
#4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid that breaking changes slip in between weekly updates on release tagging.
ax3l
commented
Aug 26, 2024
| @@ -62,15 +62,11 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Get Latest Release Tag | |||
| run: | | |||
| WARPX_TAG=$(wget https://github.com/ECP-WarpX/WarpX/releases/latest 2>&1 | grep Location: | awk '{print $2}' | awk -F/ '{print $NF}') | |||
There was a problem hiding this comment.
Discussed: ideal would be an update to find the latest commit that has the words AMReX, Update (case insensitive and arbitrary order) in it
ECP-WarpX/WarpX#5172
or Release
ECP-WarpX/WarpX#5125
or is the latest tag, whatever is newer.
|
@WeiqunZhang do we want to merge this for now? We can idealize it as described above if WarpX should surprisingly break without an AMReX update on |
WeiqunZhang
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid that breaking changes slip in between weekly updates and AMReX release tagging.
Additional background
Checklist
The proposed changes: