-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParallelFor with BoxND #4052
Merged
WeiqunZhang
merged 22 commits into
AMReX-Codes:development
from
AlexanderSinn:ParallelFor_with_BoxND
Aug 10, 2024
Merged
ParallelFor with BoxND #4052
WeiqunZhang
merged 22 commits into
AMReX-Codes:development
from
AlexanderSinn:ParallelFor_with_BoxND
Aug 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
I am a little bit worried by loops like this
where |
Maybe my last comment is not an issue. I have not noticed any performance differences in my testing. |
WeiqunZhang
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to use ParallelFor(RNG) and Loop(OnCpu) variants with BoxND.
Additional background
The functions supplied to ParallelFor etc. can have one of the following input parameter combinations when used with
BoxND<dim>
:After that come additional parameters such as
int n
,Gpu::KernelInfo
orRandomEngine
.I had to mark the constructor of GPU Handler as explicit to avoid ambiguity between (i, j, 0) and (i, j, Gpu::Handler).
Checklist
The proposed changes: