Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl Curl Solver: Option to use PCG instead of LU #3812

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

WeiqunZhang
Copy link
Member

Add support for variable beta coefficient.

Depend on #3810

@WeiqunZhang WeiqunZhang force-pushed the curl_curl_pcg branch 4 times, most recently from c45f8e9 to 4fd3e8e Compare March 17, 2024 20:02
@WeiqunZhang WeiqunZhang force-pushed the curl_curl_pcg branch 2 times, most recently from e873178 to 5cd97e3 Compare March 29, 2024 18:13
@WeiqunZhang WeiqunZhang marked this pull request as ready for review March 29, 2024 18:28
@WeiqunZhang WeiqunZhang force-pushed the curl_curl_pcg branch 2 times, most recently from 0e38741 to 1987171 Compare April 3, 2024 16:47
@WeiqunZhang WeiqunZhang force-pushed the curl_curl_pcg branch 2 times, most recently from bfe90ab to c33fea3 Compare June 16, 2024 23:15
Copy link
Contributor

@RevathiJambunathan RevathiJambunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this PR, @WeiqunZhang
It looks good to me
Left a minor spelling correction as suggestion

@WeiqunZhang WeiqunZhang requested a review from asalmgren August 27, 2024 01:11
@WeiqunZhang WeiqunZhang merged commit df0d594 into AMReX-Codes:development Aug 27, 2024
71 of 72 checks passed
@WeiqunZhang WeiqunZhang deleted the curl_curl_pcg branch August 27, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants