Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix CMake Compiler Flag Summary: ID Regex Matching (#4272)
Fixes #2978. ## Summary To understand what I'm trying to fix here, first note: https://github.com/AMReX-Codes/amrex/blob/b3f67385e62f387b548389222840486c0fffca57/Tools/CMake/AMReXFlagsTargets.cmake#L71-L95 Then, with Intel's classic compilers, configure AMReX with `-DCMAKE_BUILD_TYPE=Debug` and note the C++ flags listed under "AMReX configuration summary", before and after the changes suggested here. The gist is `Intel` as a compiler id was matching `IntelLLVM` (and `Clang` was also matching `AppleClang` though the flags in that case are the same, so it's harder to tell). EDIT: this actually only affects what's printed in the summary, the flags that are _actually_ used are already correct! The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
- Loading branch information