Skip to content

Commit

Permalink
📦 Update dependency puppeteer-core to v24 (ampproject#40226)
Browse files Browse the repository at this point in the history
* 📦 Update dependency puppeteer-core to v24

* Fixes for changed type information

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rozenberg <[email protected]>
  • Loading branch information
renovate[bot] and danielrozenberg authored Jan 10, 2025
1 parent f4123c1 commit 46da0e5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 50 deletions.
4 changes: 2 additions & 2 deletions build-system/tasks/visual-diff/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function locateChromeExecutablePath() {
* @return {!Promise<!puppeteer.Browser>} a Puppeteer controlled browser.
*/
async function launchBrowser() {
/** @type {import('puppeteer-core').PuppeteerLaunchOptions} */
/** @type {import('puppeteer-core').LaunchOptions} */
const browserOptions = {
args: [
'--disable-background-media-suspend',
Expand Down Expand Up @@ -107,7 +107,7 @@ async function newPage(browser, viewport = null) {
);
return interceptedRequest.respond({
status: 200,
body: fs.readFileSync(mockedFilepath),
body: new Uint8Array(fs.readFileSync(mockedFilepath)),
});
} else {
log(
Expand Down
56 changes: 9 additions & 47 deletions build-system/tasks/visual-diff/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build-system/tasks/visual-diff/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"@percy/puppeteer": "2.0.2",
"@percy/sdk-utils": "1.30.6",
"@puppeteer/browsers": "2.7.0",
"puppeteer-core": "23.11.1"
"puppeteer-core": "24.0.0"
}
}

0 comments on commit 46da0e5

Please sign in to comment.