Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance with CharacterOptionExtensions #4206

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Improve performance with CharacterOptionExtensions #4206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Source/ACE.Entity/Enum/CharacterOption.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,24 @@ public enum CharacterOption

public static class CharacterOptionExtensions
{
private static Dictionary<CharacterOption, CharacterOptions1Attribute> CharacterOptions1Attributes { get; }
private static Dictionary<CharacterOption, CharacterOptions2Attribute> CharacterOptions2Attributes { get; }

static CharacterOptionExtensions()
{
var vals = System.Enum.GetValues(typeof(CharacterOption)).Cast<CharacterOption>();
CharacterOptions1Attributes = vals.ToDictionary(o => o, o => o.GetAttributeOfType<CharacterOptions1Attribute>());
CharacterOptions2Attributes = vals.ToDictionary(o => o, o => o.GetAttributeOfType<CharacterOptions2Attribute>());
}

public static CharacterOptions1Attribute GetCharacterOptions1Attribute(this CharacterOption val)
{
return val.GetAttributeOfType<CharacterOptions1Attribute>();
return CharacterOptions1Attributes[val];
}

public static CharacterOptions2Attribute GetCharacterOptions2Attribute(this CharacterOption val)
{
return val.GetAttributeOfType<CharacterOptions2Attribute>();
return CharacterOptions2Attributes[val];
}

public static uint GetCharacterOptions1Flag(this ReadOnlyDictionary<CharacterOption, bool> options)
Expand Down