Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: Added section on comment commands #16

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Jan 1, 2025

In this PR:

  • Remove FIXME for image of PR process
  • Add a section in the CONTRIBUTING.md on the possible Comment Commands for Model Deployment Repositories
  • Note that Draft PRs do not require model version bumps

This is useful information and should be propagated to the Model Deployment Repositories, and ACCESS-NRI/access-hive.org.au#851

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this. Just a few questions/comments/suggestions.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CodeGat and others added 2 commits January 2, 2025 12:10
Note on format of comment commands, and important note on the users responsibility to update the references before redeploying
@CodeGat CodeGat requested a review from aidanheerdegen January 2, 2025 01:19
@tmcadam
Copy link

tmcadam commented Jan 2, 2025

I had a look at the formatting and checked links. Looks good to me.

@CodeGat
Copy link
Member Author

CodeGat commented Jan 2, 2025

Feel free to give it a tick if you want @tmcadam !

@tmcadam tmcadam self-requested a review January 2, 2025 02:15
@CodeGat CodeGat merged commit 4e2d4bf into main Jan 2, 2025
@CodeGat CodeGat deleted the contributing-comment-commands branch January 2, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants