Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embedded userdata to token #379

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

giangndm
Copy link
Contributor

Pull Request

Description

This PR allow embedded static userdata into peer token, which allow more flexible when integrate with 3rd system
Now we can set userdata field when create whip, whep or webrtc token.

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 33.64486% with 71 lines in your changes missing coverage. Please review.

Project coverage is 41.66%. Comparing base (c264d57) to head (986a5da).

Files Patch % Lines
bin/src/http/api_token.rs 0.00% 11 Missing ⚠️
bin/src/server/media/rpc_handler.rs 0.00% 9 Missing ⚠️
packages/media_runner/src/worker.rs 0.00% 9 Missing ⚠️
bin/src/server/gateway/local_rpc_handler.rs 0.00% 8 Missing ⚠️
packages/transport_webrtc/src/transport/whep.rs 0.00% 6 Missing ⚠️
packages/transport_webrtc/src/transport/whip.rs 0.00% 6 Missing ⚠️
packages/transport_webrtc/src/transport.rs 0.00% 5 Missing ⚠️
packages/transport_webrtc/src/worker.rs 0.00% 5 Missing ⚠️
bin/src/http/api_media.rs 0.00% 4 Missing ⚠️
packages/protocol/src/transport/webrtc.rs 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   41.72%   41.66%   -0.07%     
==========================================
  Files         134      134              
  Lines       14363    14416      +53     
==========================================
+ Hits         5993     6006      +13     
- Misses       8370     8410      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review July 24, 2024 10:18
@giangndm giangndm merged commit a0e80d9 into 8xFF:master Jul 24, 2024
9 checks passed
@giangndm giangndm mentioned this pull request Jul 31, 2024
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* feat: embedded userdata to token

* temp fix clippy warns
@giangndm giangndm deleted the feat-token-userdata branch November 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant