-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event-based object layout #4643
Conversation
05df6de
to
d7a2c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I do a change to a custom object and then go back to the scene, is the instance renderer adapting properly? If not, do I need to re-open the scene (and what do we need to do so that it works seamlessly?)
newIDE/app/src/ObjectsRendering/Renderers/RenderedCustomObjectInstance.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
There is a lot of logic which can be only "visually tested". I"m not sure we want a full test suite for this, but at the same time I have the feeling this will stay for a very long time in the app.
I think it would be worth at some point having a unit test with a few programmatically created custom objects and check that the rendered child-instances are put at the right positions.
Last stuff: double check if we should say child-objects or child-instances in all the comments, to be sure we use the proper word :)
newIDE/app/src/ObjectsRendering/Renderers/RenderedCustomObjectInstance.js
Outdated
Show resolved
Hide resolved
I added this in a comment. As there is a 1 to 1 relation between objects and instances, I think it won't be too much confusing. |
return this.height; | ||
} | ||
|
||
addChid( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere: addChid => addChild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after the fix for the typo.
Demo
GDevelopApp/GDevelop-examples#411