Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-based object layout #4643

Merged
merged 22 commits into from
Dec 23, 2022
Merged

Event-based object layout #4643

merged 22 commits into from
Dec 23, 2022

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Dec 8, 2022

@D8H D8H force-pushed the ebo-layout branch 3 times, most recently from 05df6de to d7a2c0a Compare December 14, 2022 14:16
@D8H D8H changed the title WIP: Event-based object layout Event-based object layout Dec 14, 2022
@D8H D8H marked this pull request as ready for review December 14, 2022 16:00
@D8H D8H requested a review from 4ian as a code owner December 14, 2022 16:00
Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do a change to a custom object and then go back to the scene, is the instance renderer adapting properly? If not, do I need to re-open the scene (and what do we need to do so that it works seamlessly?)

Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
There is a lot of logic which can be only "visually tested". I"m not sure we want a full test suite for this, but at the same time I have the feeling this will stay for a very long time in the app.
I think it would be worth at some point having a unit test with a few programmatically created custom objects and check that the rendered child-instances are put at the right positions.

Last stuff: double check if we should say child-objects or child-instances in all the comments, to be sure we use the proper word :)

@D8H
Copy link
Collaborator Author

D8H commented Dec 23, 2022

Last stuff: double check if we should say child-objects or child-instances in all the comments, to be sure we use the proper word :)

  • The term "object" is used in comments about the layout declaration because the layout is done with one instance per object-child and the object name is used to reference these instances.
  • The term "instance" is used for the layout calculus because it's actually instances that are in the scene editor.

I added this in a comment. As there is a 1 to 1 relation between objects and instances, I think it won't be too much confusing.

return this.height;
}

addChid(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere: addChid => addChild

Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the fix for the typo.

@D8H D8H merged commit 9f7c1a1 into master Dec 23, 2022
@D8H D8H deleted the ebo-layout branch December 23, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants