Reset scroll when changing search text

4ian · Jan 10, 2025 · 6e112ca · 6e112ca
1 parent 1f2c83e
commit 6e112ca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/newIDE/app/src/EventsSheet/InstructionEditor/InstructionOrObjectSelector.js b/newIDE/app/src/EventsSheet/InstructionEditor/InstructionOrObjectSelector.js
@@ -360,9 +360,13 @@ const InstructionOrObjectSelector = React.forwardRef<
 
     React.useEffect(
       () => {
-        if (treeViewRef.current) treeViewRef.current.updateRowHeights();
+        const treeView = treeViewRef.current;
+        if (treeView) {
+          treeView.updateRowHeights();
+          treeView.scrollTo(0);
+        }
       },
-      // Recompute row heights when search changes.
+      // Recompute row heights when search changes and reset scroll.
       [searchText]
     );
 

diff --git a/newIDE/app/src/UI/TreeView/ReadOnlyTreeView.js b/newIDE/app/src/UI/TreeView/ReadOnlyTreeView.js
@@ -67,6 +67,7 @@ const getItemProps = memoizeOne(
 
 export type ReadOnlyTreeViewInterface<Item> = {|
   forceUpdateList: () => void,
+  scrollTo: (offset: number) => void,
   scrollToItem: (Item, placement?: 'smart' | 'start') => void,
   scrollToItemFromId: (itemId: string, placement?: 'smart' | 'start') => void,
   openItems: (string[]) => void,
@@ -364,6 +365,13 @@ const ReadOnlyTreeView = <Item: ItemBaseAttributes>(
     [getItemId, scrollToItemFromId]
   );
 
+  const scrollTo = React.useCallback((offset: number) => {
+    const list = listRef.current;
+    if (list) {
+      list.scrollTo(offset);
+    }
+  }, []);
+
   const openItems = React.useCallback(
     (itemIds: string[]) => {
       const notAlreadyOpenedNodeIds = itemIds.filter(
@@ -448,6 +456,7 @@ const ReadOnlyTreeView = <Item: ItemBaseAttributes>(
     ref,
     () => ({
       forceUpdateList: forceUpdate,
+      scrollTo,
       scrollToItem,
       scrollToItemFromId,
       openItems,