Limit line length to 400 in JS #5362
Open
+104
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we got some lines up to 700 characters long.
This is not the best :
I set to 400, I hope temporary. Before going further, I would like your idea. Optimum is 120, 130 (to have two files side-by-side, without softwrap). Also in GitHub/GitLab UI, lines are 120 characters.
If a line is more than 130, it's means that the code should be refactored, to introduce an intermediate variable.
Keen to have feedbacks : @mind84 @nworr @mdouchin @nboisteault @rldhont