Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests e2e : checking print request parameters #5267

Closed
wants to merge 32 commits into from

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Jan 27, 2025

Refactoring the way to checking print request parameters to be sure th UI generated the right parameters.

@rldhont rldhont added tests unit tests and docker configuration for tests refactoring run end2end If the PR must run end2end tests or not labels Jan 27, 2025
@github-actions github-actions bot added this to the 3.10.0 milestone Jan 27, 2025
@rldhont rldhont force-pushed the tests-e2e-print-request branch 2 times, most recently from c2adb4a to 0c514a4 Compare January 28, 2025 17:03
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, way nicer !

@josemvm
Copy link
Collaborator

josemvm commented Jan 29, 2025

hi @rldhont is thsi related #4984 ?

@rldhont
Copy link
Collaborator Author

rldhont commented Jan 29, 2025

@josemvm nope it is just a refactory

@rldhont rldhont marked this pull request as draft January 29, 2025 10:32
@rldhont rldhont force-pushed the tests-e2e-print-request branch from da98fc4 to 2980fa4 Compare January 29, 2025 17:02
@Gustry
Copy link
Member

Gustry commented Jan 31, 2025

Just to keep track, we just have the error on CI on another PR : #5303

    Expected substring: "TRANSPARENT=true"
    Received string:    "http://localhost:8130/index.php/lizmap/service?repository=testsrepository&project=axis_orientation_neu_3844&REQUEST=GetMap&SERVICE=WMS&VERSION=1.3.0&FORMAT=image%2Fpng&STYLES=default&TRANSPARENT=TRUE&LAYERS=judet&DPI=96&WIDTH=958&HEIGHT=633&CRS=EPSG%3A3844&BBOX=72126.0026920751%2C-122200.57244003483%2C909533.9275079248%2C1145156.1289400347"
      90 |         expect(getMapUrl).toContain('REQUEST=GetMap');
      91 |         expect(getMapUrl).toContain('FORMAT=image%2Fpng');
    > 92 |         expect(getMapUrl).toContain('TRANSPARENT=true');

When checking parameters, with your helper, about the casse

@rldhont rldhont force-pushed the tests-e2e-print-request branch from 2980fa4 to d7397d2 Compare January 31, 2025 16:54
@rldhont rldhont marked this pull request as ready for review January 31, 2025 16:54
@rldhont rldhont force-pushed the tests-e2e-print-request branch from d491657 to fed491a Compare January 31, 2025 17:26
@Gustry Gustry self-requested a review January 31, 2025 17:32
@rldhont
Copy link
Collaborator Author

rldhont commented Feb 1, 2025

This PR is too long with too many commits and reveal some misconception in certain tests. I will split it in dedicated PR, starting with Print in project projection tests #5323

@Gustry
Copy link
Member

Gustry commented Feb 3, 2025

So this PR can be closed ?
#5323 has been merged and backported.
#5324 is the new PR

@rldhont
Copy link
Collaborator Author

rldhont commented Feb 3, 2025

Yes @Gustry, I close it.

@rldhont rldhont closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 backport release_3_9 refactoring run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants