Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: incorrect replacement in <a href="media/"><img src="media/"></a> #5251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Jan 21, 2025

#(["\']){1}((\.\./)?media/.+\.\w{3,10})(["\']){1}# is replaced by #["\']((\.\./)?media/.+?\.\w{3,10})["\']#

.+ part is made ungreedy

Funded by 3Liz

@github-actions github-actions bot added this to the 3.10.0 milestone Jan 21, 2025
@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Jan 21, 2025
@rldhont rldhont requested a review from mdouchin January 21, 2025 17:00
@nboisteault nboisteault force-pushed the fix-popup-multiple-media branch from 29ce894 to fe5aeb4 Compare January 27, 2025 16:32
@nboisteault nboisteault force-pushed the fix-popup-multiple-media branch from fe5aeb4 to 61e36aa Compare January 27, 2025 16:48
@nboisteault nboisteault force-pushed the fix-popup-multiple-media branch from 61e36aa to 2147c6c Compare January 28, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 backport release_3_9 run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants