Update Mumble.proto from the Mumble master #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was taken from master on the 2024-11-09[1]. I’m worried about the compatibility with MumbleWithWebRTC.proto, which uses fields which are now used by the upstream protocol. See its issue upstream[2], which hasn’t been updated in four years. [1] mumble-voip/mumble@9c48561 [2] mumble-voip/mumble#3561
|
Sorry, I didn't see any of your PRs until now and only saw them by chance! (edit: or actually because I got pinged about them) |
|
Don’t worry about that, I wasn’t waiting on them or anything. Do you have another way you prefer to get notified if I make further ones? |
|
I'm now watching the repo, wasn't for some reason. I'll see them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was taken from master on the 2024-11-09.
I’m worried about the compatibility with MumbleWithWebRTC.proto, which uses fields which are now used by the upstream protocol. See its issue upstream, which hasn’t been updated in four years.