Restore faker for development environments #11786
Conversation
…ality by including faker in development/test gemfile group
eileen-nava
changed the title
| @@ -105,6 +105,7 @@ group :development, :test do | |||
| gem 'bullet', '~> 7.0' | |||
| gem 'capybara-webmock', git: 'https://github.com/hashrocket/capybara-webmock.git', ref: 'd3f3b7c' | |||
| gem 'erb_lint', '~> 0.7.0', require: false | |||
| gem 'faker' | |||
There was a problem hiding this comment.
let's add an explicit require in the mailer preview too? or maybe a comment here noting why it's here?
| gem 'faker' | |
| gem 'faker', require: false # used in mailer previews |
There was a problem hiding this comment.
Is the motivation making the bundle smaller, so that performance is improved? Or ensuring that faker doesn't mistakenly get removed from development in the future?
I'm not against the change, just want to be sure I understand the benefit.
There was a problem hiding this comment.
the comment is to make sure it doesn't get removed in the future
the require: false is because we don't strictly need that in memory for our "normal" production flow so this just helps keep things small and explicit
There was a problem hiding this comment.
Unless I'm misunderstanding something, moving from :test to the :development, :test group shouldn't impact production?
🛠 Summary of changes
Shane and I worked on this during our 1:1. The user mailer was broken because faker was missing. I included a screenshot of the error. We restored faker and the user mailer looks a-okay now.
📜 Testing Plan
👀 Screenshots
Error: