LG-15392 Remove the locale param from the post-IdV follow-up URL #11781
+1
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added the locale param to the post-IdV follow-up URL as a short term solution for a partner who needed to get the user's locale when they clicked that link. In #11756 we made a change that allows SPs to request the locale via the OIDC claims or SAML attributes. This should resolve the issue for that partner. This commit removes support for including the locale as a param on the post-IdV follow-up URL. It should not be merged until: 1. Our partner has configured their application to request the locale in the OIDC params 2. We have removed the templated locale value from their configured post-IdV follow-up URL [skip changelog]
|
We have 2 conditions for merging this PR. I am going to label it "DO NOT MERGE" while we wait for those to be resolved. |
aduth
approved these changes
Jan 22, 2025
mitchellhenke
approved these changes
Jan 22, 2025
Sgtpluck
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the locale param to the post-IdV follow-up URL as a short term solution for a partner who needed to get the user's locale when they clicked that link. In #11756 we made a change that allows SPs to request the locale via the OIDC claims or SAML attributes. This should resolve the issue for that partner.
This commit removes support for including the locale as a param on the post-IdV follow-up URL. It should not be merged until: