Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15273 Create a Redis Set to track Socure users #11773

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

theabrad
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-15273

🛠 Summary of changes

We created a redis set to track unique socure users and keep a count of them. This gives us the ability to add users and to check the count of socure users.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Check that the specs test the correct functionality and that they pass

theabrad and others added 4 commits January 17, 2025 13:26
changelog: Internal, Doc Auth Socure, Create a Redis set to track Socure users
Copy link
Member

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmargolis
Copy link
Contributor

How long is this meant to be kept around for?

@theabrad
Copy link
Contributor Author

How long is this meant to be kept around for?

We are keeping it around until we can lift the limit of socure users allowed in.

@zachmargolis
Copy link
Contributor

How long is this meant to be kept around for?

We are keeping it around until we can lift the limit of socure users allowed in.

I think in that case, maybe REDIS_POOL might be a better fit? I feel like the throttle pool is something we could wipe out and expect the application to recover from easily, but this would not survive as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants