Deploy RC 378 to Production #10578
Merged
Deploy RC 378 to Production #10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add update route * add update to state id controller * fix back issue for state id pg * update address url and ensure user taken to address pg if change same address from true to false * add update specs to controller spec * fix a failing spec * fix failing analytics test * move variables * changelog: Internal, State id, update route for controller version * lint fix * use pii_from_user * remove reference to addressStep * remove if redirect_url
* LG-12553: A/B Test for 10-digit IdV OTP This PR sets up an A/B test where one group gets the current six alphanumeric character OTP, and the other group gets the new ten numeric digit OTP under test. The test bucket they are put in is logged in most IdV events. changelog: User-Facing Improvements, Identity Verification, A/B test to try out 10-digit voice OTP for Identity Verification
…0552) * LG-13106: Post-LQA Content Error Fix | Step-up user GS in Spanish Fixing one word in the translation. [skip changelog] * make normalize_yaml
* Bump libphonenumber-js from 1.10.61 to 1.11.0 Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.61 to 1.11.0. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.61...v1.11.0) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Use parsePhoneNumber to get correct NationalNumber type * Just cast it * Update app/javascript/packages/phone-input/index.ts Co-authored-by: Andrew Duthie <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zach Margolis <[email protected]> Co-authored-by: Zach Margolis <[email protected]> Co-authored-by: Andrew Duthie <[email protected]>
* LG-12062: Change the step indicator step description of the request letter page. While the ticket asked for a simple copy change for the Step Indicator on just one screen, the conditional logic involved, as well as discovered bugs, resulted in a comprehensive audit of the Step Indicator on all paths through Identity Verification. More than a dozen screens ended up with changes. changelog: User-Facing Improvements, Identity Verification, Updates the step indicator on all IdV paths. * remove commented out translation keys and unused instance variable * Update app/controllers/idv/personal_key_controller.rb * hardcode step in by_mail/request_letter/index.html.erb * remove obsolete specs --------- Co-authored-by: Matt Hinz <[email protected]>
* LG-12873: Annotate reCAPTCHA assessments with MFA results changelog: Internal, Spam Mitigation, Annotate reCAPTCHA assessments with MFA results * Ensure consistent return signature in error handling * Update reCAPTCHA specs * Update feature specs expected reCAPTCHA logging * Target enterprise feature support for annotation submission * Add RecaptchaAnnotator specs * Fix request structure for Enterprise usage * Avoid passing legitimate OTP submission Maybe temporarily, clarifying best practices * Inline reasons with compacted requested body See: #10522 (comment) Co-authored-by: Zach Margolis <[email protected]> * Embed annotation into existing analytics events * Remove standalone recaptcha_assessment_annotated event As of dcc31d1, annotation details are now embedded in related event as property hash * Handle connection error --------- Co-authored-by: Zach Margolis <[email protected]>
Removed all references to `sp_session[:biometric_comparison_required]` Turned out to be mostly spec changes. changelog: Internal,Vector of Trust,Removed use of sp_session[:biometric_comparison_required]
#10563) changelog: Internal, Build Tooling, Resolve nested selectors with Stylelint selector-class-pattern configuration
…ard (#10564) * Replace stylelint-config-recommended-scss with stylelint-config-standard-scss changelog: Internal, Build Tools, Replace stylelint-config-recommended-scss with stylelint-config-standard-scss * Disable color-function-notation Due to Sass incompatibilities See: sass/sass#2831 * Fix lint errors * Bump version to 5.0.0-beta.1 * Move reportNeedlessDisables into shared configuration
* Bump libphonenumber-js from 1.11.0 to 1.11.1 Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.0 to 1.11.1. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Remove hard cast used for previous patch * Remove unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zach Margolis <[email protected]>
…ics Names (#10566) * add blanket, intent, actual, and industry proofing rate to DIVR * added entries for rates in specs * LG-12181 Update metrics names for DIVR updated the metrics names for DIVR * embed IdV report into ProofingRateReport the methods for proofing rates now read from the IdentityVerificationReport rather than being created in the ProofingRateReport * add changelog changelog: Internal, IdV, Add Proofing Rate Metrics to IdentityVerificationReport and rename metrics names * call methods inline * fix specs with metrics renames
* resolve merge conflicts * remove specs testing image escrow * remove enrypted_document_storage vars from identity config * changelog: Internal, Document Authentication, Remove implementation of document escrow
* Bump @18f/identity-design-system from 9.1.0 to 9.2.0 Bumps [@18f/identity-design-system](https://github.com/18F/identity-design-system) from 9.1.0 to 9.2.0. - [Release notes](https://github.com/18F/identity-design-system/releases) - [Changelog](https://github.com/18F/identity-design-system/blob/main/CHANGELOG.md) - [Commits](18F/identity-design-system@v9.1.0...v9.2.0) --- updated-dependencies: - dependency-name: "@18f/identity-design-system" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update BadgeComponent to avoid deprecated markup LGDS 9.2.0 updated markup, which will become breaking change in LGDS 10 * Add upstream reference for temporary patch --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Duthie <[email protected]>
…information to [Partner Agency]” (#10405) * create view, controller, and route * create page * redirect to new page * WIP: work on redirect * create presenter * Connect URL with button * change buttons to links * fix layout changelog: User-facing improvements, redirect, redirect user when canceling after first method setup * test when no SP is provided * fix test for analytics on cancel * update test names * edit controller spec * delete presenter, do url logic in controller * slash and burn: keep everything in `return_to_sp_controller` * fix titles * consolidate to cancel path * lint all the things * fix return to sp tests * fix test for completions show * fix uri test * fix interpolations, delete unused confirm view * lintfix * i18n lint fixes * fix test for redirect URI * Add test for end-to-end spec * fix js test from testing * Fix interpolation * add step, remove unused path * add test for no sp provided, more descriptive test names * change `login_exit` -> `login_cancel` * Edit string for login_cancel.header * lint, use `StatusPageComponent` * fix missing keys error * add param and associated check * fix `return_to_sp` test * Update app/views/redirect/return_to_sp/cancel.html.erb Co-authored-by: Andrew Duthie <[email protected]> * new controller and view * analytics, polish view and controller * re-trigger build * fix tests * lintfix and fix up failing tests * add analytics * edit controller, write test, and fix failing spec * move files from redirect =>separate controller, move file, edit route * fix view test * move strings to new file, update in view * add controller test * change where strings live and update view accordingly * Update app/controllers/completions_cancellation_controller.rb Co-authored-by: Andrew Duthie <[email protected]> * Update spec/controllers/completions_cancellation_controller_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * Update config/routes.rb Co-authored-by: Andrew Duthie <[email protected]> * Update config/locales/login_cancel/en.yml Co-authored-by: Andrew Duthie <[email protected]> * add html, lintfix * more lint errors * fix tests, analytics, and paths * Update spec/features/account_creation/completions_cancel_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * Update spec/features/account_creation/completions_cancel_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * Update spec/features/account_creation/completions_cancel_spec.rb Co-authored-by: Andrew Duthie <[email protected]> * Add chinese translations * sort analytics event, fix missing keys * fix test * double check `login_cancel` strings, add missing title * need to remove one more letter, normalize --------- Co-authored-by: Andrew Duthie <[email protected]>
* LG-13044: Step indicator LQA updates [skip changelog] * update `verify_id` French
…10548) * Document analytics parameters to allow unexempted completions feature spec changelog: Internal, Documentation, Document additional analytics events properties * Optimistically assume we fixed everything * Re-exempt still-failing specs
* Remove prod check * changelog: Internal, In-Person Proofing, Remove hardcoded prod block for selfie feature * Remove tests for the prod blocker
Add link to doc describing what these metrics mean. [skip changelog]
This was included in RC 377 so could be excluded from these notes. |
aduth
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal