Passed the whole user object to make use of the instance methods

[cholalabs]

User.setter.password = function(pass) {
        this.salt = this.makeSalt();
        this._password = this.encryptPassword(pass);
    };

    User.prototype.authenticate = function(plainText) {
        return this.encryptPassword(plainText) === this.password;
    }

    User.prototype.makeSalt = function(date) {
        return Math.round(((date || new Date()).valueOf() * Math.random()))
                + '';
    }

    User.prototype.encryptPassword = function(password) {
        return crypto.createHmac('sha1', this.salt).update(password).digest(
                'hex');
    }
    User.beforeUpdate = function(next) {
        this.modified_on = new Date();
        next();
    }

    User.verifyPassword = function(userpassword, user) {
        return user.authenticate(userpassword);
    };

[1602]

I'm afraid this may break existing code.

[cholalabs]

Hi,
Is there any alternative you can suggest to handle the instance methods
with the existing code?

On Sat, Jan 18, 2014 at 4:45 PM, Anatoliy Chakkaev <[email protected]

wrote:

I'm afraid this may break existing code.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-32695554
.

Warm Regards
Suresh
Chola Team

[1602]

It should be an instance method of user then, and not class method which
takes instance as a param.

On Sun, Jan 19, 2014 at 4:40 AM, cholalabs [email protected] wrote:

Hi,
Is there any alternative you can suggest to handle the instance methods
with the existing code?

On Sat, Jan 18, 2014 at 4:45 PM, Anatoliy Chakkaev <
[email protected]

wrote:

I'm afraid this may break existing code.

—
Reply to this email directly or view it on GitHub<
https://github.com/1602/compound-passport/pull/24#issuecomment-32695554>
.

Warm Regards
Suresh
Chola Team

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-32700953
.

Thanks,
Anatoliy Chakkaev