Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when virtual template format is invalid #3509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Throw error when virtual template format is invalid #3509

wants to merge 2 commits into from

Conversation

dave-kennedy
Copy link

It took a while to realize my Atom feed wasn't being created because of this 😅

@zachleat zachleat added this to the Eleventy 4.0.0 milestone Dec 11, 2024
@zachleat zachleat added the breaking-change This will have to be included with a major version as it breaks backwards compatibility. label Dec 11, 2024
@zachleat
Copy link
Member

Runninng a poll on this one: https://fosstodon.org/@eleventy/113635193378918851

Unfortunately this would be a breaking change so we’ll have to milestone for 4.0

@zachleat zachleat added needs-discussion Please leave your opinion! This request is open for feedback from devs. on-hold labels Dec 11, 2024
@dave-kennedy dave-kennedy mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachleat zachleat Awaiting requested review from zachleat zachleat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. needs-discussion Please leave your opinion! This request is open for feedback from devs. on-hold
Projects
None yet
Milestone
Eleventy 4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-kennedy @zachleat