-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Interdire l'HTML sur les champs qui ne le permettent pas (PIX-10243) (PIX-10241) #8668
Merged
pix-service-auto-merge
merged 1 commit into
dev
from
pix-10243-forbid-html-on-specific-fields
Apr 18, 2024
Merged
[FEATURE] Interdire l'HTML sur les champs qui ne le permettent pas (PIX-10243) (PIX-10241) #8668
pix-service-auto-merge
merged 1 commit into
dev
from
pix-10243-forbid-html-on-specific-fields
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
3a2dc49
to
34858aa
Compare
34858aa
to
bffb8a0
Compare
bffb8a0
to
81bf129
Compare
81bf129
to
9e531ee
Compare
...evcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js
Outdated
Show resolved
Hide resolved
9e531ee
to
e2c3b0c
Compare
e2c3b0c
to
23d9162
Compare
export { htmlSchema, proposalIdSchema, uuidSchema }; | ||
const htmlNotAllowedSchema = Joi.string() | ||
.regex(/<.*?>/, { invert: true }) | ||
.message('{{:#label}} failed custom validation because HTML is not allowed in this field'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A garder dans un coin de la tête pour une prochaine fois !
dlahaye
suggested changes
Apr 17, 2024
...evcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebeca Kaci <[email protected]> Co-authored-by: Dimitri Lahaye <[email protected]>
23d9162
to
397c07a
Compare
yannbertrand
approved these changes
Apr 18, 2024
dlahaye
approved these changes
Apr 18, 2024
mirawlin
approved these changes
Apr 18, 2024
VincentHardouin
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
En tant que l'equipe contenu qui redige les modules, ils sont pas notifier si un champ peut contenir HTML ou pas.
🤖 Proposition
Ajouter validation pour les champs qui doivent pas contenir HTML.
🌈 Remarques
Pour le schema QROCM Block Select options, on a vu qu'il n'y a pas un minimum des options dans le joi schema. Il faut ajouter un minimum de 2 option.
💯 Pour tester
CI passe
En local:
bien-ecrire-son-adresse-mail.json
alt
Par exemple :