[FEATURE] Pix Junior - Utiliser les options de validation de challenge provenant de Pix Editor #11296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
aurelie-crouillebois
force-pushed
the
pix-16315-use-new-challenges-column-in-pix-junior
branch
from
475f537 to
6dc13df
Compare
aurelie-crouillebois
changed the title
aurelie-crouillebois
added
👀 Tech Review Needed
👀 Func Review Needed
aurelie-crouillebois
force-pushed
the
pix-16315-use-new-challenges-column-in-pix-junior
branch
from
6dc13df to
e3f650e
Compare
aurelie-crouillebois
changed the title
mcampourcy
approved these changes
Feb 4, 2025
rouxxi
reviewed
Feb 4, 2025
Comment on lines
+47
to
+48
| hasEmbedInternalValidation: true, | ||
| noValidationNeeded: true, |
There was a problem hiding this comment.
Ce cas n'existe pas ?
Il ne vaut pas mieux faire des true/false ou false/true ?
There was a problem hiding this comment.
L'idée était surtout de faire des tests techniques (passage de false à true ou pas...).
Les challenges ne sont pas "réalistes", ici, c'est un QCU avec autoReply à true par exemple.
Comment on lines
+88
to
90
| hasEmbedInternalValidation: true, | ||
| noValidationNeeded: true, | ||
| }; |
Comment on lines
+537
to
+539
| hasEmbedInternalValidation: true, | ||
| noValidationNeeded: true, |
Comment on lines
+592
to
+594
| hasEmbedInternalValidation: true, | ||
| noValidationNeeded: true, |
aurelie-crouillebois
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
pix-16315-use-new-challenges-column-in-pix-junior
branch
from
e3f650e to
27b37a3
Compare
pix-service-auto-merge
deleted the
pix-16315-use-new-challenges-column-in-pix-junior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Dans Pix Junior, les données focus et timer sont détournées de leur usage pour gérer des cas spécifiques de validation des épreuves :
les leçons contenant uniquement des vidéos ou des fiches récapitulatives sans besoin de validation
les épreuves embeds avec validation interne comme les gdevelop ou les embeds pixwriter de mise en forme.
🥓 Proposition
Utiliser les 2 nouvelles colonnes dans le challenge contenant ces informations.
😋 Pour tester
Non régression :
Les épreuves indiquées comme focus continuent à s'afficher sans bouton de vérification.
Les épreuves contenant un timer continuent de bénéficier d'une validation automatique.
Test de l'utilisation des nouvelles infos :
Modifier une épreuve contenant le flag focus, et positionne le flag noValidationNeeded. Le comportement reste inchangé.
Modifier une épreuve contenant un timer, et positionne le flag hasEmbedInternalValidation. Le comportement reste inchangé.