Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajout videos module souris-1 #11283

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

PhilomeneChivard
Copy link
Contributor

@PhilomeneChivard PhilomeneChivard commented Jan 30, 2025

🥞 Problème

Ajout des vidéos dans le module Souris 1

🥓 Proposition

🧃 Remarques

😋 Pour tester

https://app-pr11283.review.pix.fr/modules/utiliser-souris-ordinateur-1

Copy link
Contributor

Les tests Modulix ont échoué. Voici les détails :


> [email protected] modulix:test
> npm run test:api:path -- 'tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js' 'tests/devcomp/acceptance/module-instantiation_test.js' 'tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js'


> [email protected] test:api:path
> NODE_ENV=test mocha --exit --recursive --reporter=${MOCHA_REPORTER:-dot} tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js tests/devcomp/acceptance/module-instantiation_test.js tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js

(node:2001) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)


  ............!.............................

  41 passing (8s)
  1 failing

  1) Unit | Infrastructure | Datasources | Learning Content | ModuleDatasource
       #list
         modules content
           module "utiliser-souris-ordinateur-1" should contain a valid structure:
     AssertionError: 
============================================================

Error: "grains[1].components[1].element.poster" is not allowed to be empty.
Valeur concernée à rechercher : ""

────────────────────────────────────────────────────────────

Error: "grains[3].components[1].element.poster" is not allowed to be empty.
Valeur concernée à rechercher : ""

============================================================
: expected ValidationError: "grains[1].components[1]… { …(2) } to equal undefined
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js:46:33)



@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@PhilomeneChivard PhilomeneChivard changed the title feat(api): ajout des vidéos dans souris1 [FEATURE] Ajout videos module souris-1 Jan 30, 2025
@PhilomeneChivard PhilomeneChivard force-pushed the pch-1emarche-souris-videos branch from 268722a to b523f2a Compare January 31, 2025 11:26
Copy link
Contributor

@RomainPennec RomainPennec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci pour le "nettoyage" html en plus de l'ajout vidéo !

@pix-service-auto-merge pix-service-auto-merge merged commit f1392a2 into dev Jan 31, 2025
6 of 9 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pch-1emarche-souris-videos branch January 31, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants