Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Utiliser le nouveau layout dans PixApp (PIX-16302). #11281

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

Jeyffrey
Copy link
Contributor

@Jeyffrey Jeyffrey commented Jan 30, 2025

🥓 Proposition

Mettre à jour PixApp avec un nouveau layout.

  • Utiliser les composants PixUI PixAppLayout et PixNavigation.
  • Se protéger sous feature-toggle FT_PIXAPP_NEW_LAYOUT_ENABLED

🧃 Remarques

1 Les entrées de la barre de nav

  • Reprendre les mêmes comportements que l’actuel, c’est-à-dire :
  • afficher à tous les onglets Accueil, Compétences, Certifications
  • n’afficher les onglets Mes parcours, Mes formations qu’aux utilisateurs ayant débloqué l’accès
  • conserver les spécificités de l’onglet Certifications : l'écran n’est pas le même si l’utilisateur est certifiable ou non

2 Afficher le centre d’aide en bas de la nav

3 Créer un header pour afficher le score Pix, “J’ai un code” et “[Prénom]” sur tous les écrans

😋 Pour tester

Aller sur PixApp en RA (le feature-toggle est déjà activé).

  • Vérifier le comportement desktop vs mobile
  • Constater que la Marianne n'est là que sur le .fr

@Jeyffrey Jeyffrey added Development in progress team-evaluation PR relatives à l'expérience d'évaluation labels Jan 30, 2025
@Jeyffrey Jeyffrey self-assigned this Jan 30, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@Jeyffrey Jeyffrey force-pushed the pix-16302-new-pix-app-navigation branch 4 times, most recently from 402907c to 3bc60ca Compare January 30, 2025 15:39
@Jeyffrey Jeyffrey added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Jan 30, 2025
@Jeyffrey Jeyffrey marked this pull request as ready for review January 30, 2025 15:40
@Jeyffrey Jeyffrey force-pushed the pix-16302-new-pix-app-navigation branch 2 times, most recently from c811bf6 to 9182664 Compare January 30, 2025 15:54
@Jeyffrey Jeyffrey force-pushed the pix-16302-new-pix-app-navigation branch from 9182664 to f8f5212 Compare January 31, 2025 13:26
@Jeyffrey Jeyffrey added Tech Review OK 🚀 Ready to Merge Func Review OK PO validated functionally the PR and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Jan 31, 2025
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-16302-new-pix-app-navigation branch from f8f5212 to 02156b4 Compare January 31, 2025 13:56
@Jeyffrey Jeyffrey closed this Jan 31, 2025
@Jeyffrey Jeyffrey reopened this Jan 31, 2025
@Jeyffrey Jeyffrey closed this Jan 31, 2025
@1024pix 1024pix deleted a comment from pix-bot-github Jan 31, 2025
@Jeyffrey Jeyffrey reopened this Jan 31, 2025
@Jeyffrey Jeyffrey force-pushed the pix-16302-new-pix-app-navigation branch from 02156b4 to bb53ee3 Compare January 31, 2025 14:44
@1024pix 1024pix deleted a comment from pix-bot-github Jan 31, 2025
@pix-service-auto-merge pix-service-auto-merge merged commit c65f4e5 into dev Jan 31, 2025
9 of 10 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-16302-new-pix-app-navigation branch January 31, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-evaluation PR relatives à l'expérience d'évaluation Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants