[TECH] Corriger le test flaky d'une méthode dans le repository target-profiles #11275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
machestla
approved these changes
Jan 30, 2025
pix-service-auto-merge
force-pushed
the
pix-16331-fix-flaky-on-target-profile-repository
branch
from
36c09e5 to
be82506
Compare
pix-service-auto-merge
deleted the
pix-16331-fix-flaky-on-target-profile-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Nous avons un flaky sur le test suivant (l'ordre n'étant pas garanti)
🥓 Proposition
On corrige le flaky en vérifiant que le contenu et pas son ordre.
J'ai volontairement inversé l'ordre des PC dans le tableau pour expliciter le flaky et que le test soit plus précis
🧃 Remarques
Je ne pense pas que ce soit pertinent dans ce cas d'ajouter un order dans la méthode de repo car on ne l'utilise pas du tout. Et ça obligeait possiblement a modifier d'autres tests
J'ai ajouté des noms aux profils cibles juste pour faciliter la lecture quand on debug, ça évite les doublons de noms
😋 Pour tester