[TECH]: lmite le nombre de méthode de knowledgeElementRepository (Pix-15758) #11274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
force-pushed
the
pix-15758/get-ke-snapshots-through-campaignParticipationId
branch
from
9775901 to
b303bfb
Compare
…ignParticipationId
…inlined method to count ke
alicegoarnisson
force-pushed
the
pix-15758/get-ke-snapshots-through-campaignParticipationId
branch
from
b303bfb to
ed2f60c
Compare
alicegoarnisson
deleted the
pix-15758/get-ke-snapshots-through-campaignParticipationId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
On souhaite récupérer les keSnapshot depuis une participation, or pour l'instant la méthode
findSnapshotForUserscomplique cela car elle peut etre utilisé pour récupérer dessnapshotsou deske. on souhaite donc séparer cet usage au niveau desrepositoriesen 2 méthodesfindKeForUsersetfindSnapshotForUsers.🥓 Proposition
Dans un premier temps, on souhaite simplifier et rendre explicite les usages de
findSnapshotForUsersafin de déterminer ceux que l'on pourra remplacer par l'une ou l'autre des méthodes et on introduit une méthodefindKnowledgeElementsForUsersdans le repositoryknowledgeElement🧃 Remarques
😋 Pour tester