-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Conditionner la validation des AT utilisateurs en comparant l’aud des AT utilisateurs à la forwardedOrigin (PIX-15944) #11208
Open
lego-technix
wants to merge
9
commits into
dev
Choose a base branch
from
pix-15944-check-audience-in-AT-for-authentication
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
lego-technix
assigned P-Jeremy and lego-technix and unassigned P-Jeremy and lego-technix
Jan 24, 2025
lego-technix
force-pushed
the
pix-15944-check-audience-in-AT-for-authentication
branch
3 times, most recently
from
January 25, 2025 19:26
a63456b
to
abd68e6
Compare
…them from audience validation
…ers helper to have a valid authentication through a user Access Tokens now with audience
…estHeaders helper to have a valid authentication through a user Access Tokens now with audience
…stHeaders helper to have a valid authentication through a user Access Tokens now with audience
lego-technix
force-pushed
the
pix-15944-check-audience-in-AT-for-authentication
branch
from
January 26, 2025 14:26
abd68e6
to
c3fec9b
Compare
lego-technix
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
C'est la suite de #11207
Maintenant que chaque Access Token utilisateur est porteur d'une
audience
(enregistrée dans le JWT avec la propriétéaud
), on peut vérifier, au niveau de la couche applicative, que cetteaudience
légitime correspond bien au frontal auquel l'Access Token est envoyé.🥓 Proposition
Mettre en place, au niveau de la couche applicative, un mécanisme de vérification vérifiant que l’
aud
de chaque Access Token utilisateur correspond bien au frontal auquel l'Access Token est envoyé.Cette PR active le Feature Toggle (FT)
FT_USER_TOKEN_AUD_CONFINEMENT_ENABLED
pour tous les tests, de manière à valider que le dispositif mis en place est bien fonctionnel dans tous les cas et qu’aucune régression dans son fonctionnement ne puisse arriver avant l'activation définitive et non-optionnelle du mécanisme de vérification de l’audience.Mais cette PR n'active pas encore la vérification que l’
aud
de chaque Access Token utilisateur. Pour cela il faut toujours activer le FT de la manière suivante :🧃 Remarques
Une fois que #11207 est mergée :
dev
feat(api): mark anonymous Access Tokens as such to temporary exlcude them from audience validation
feat(api): validate audience of non-anonymous user Access Tokens
en enlevant la condition!decodedAccessToken.anonymous
😋 Pour tester
Faire les tests fonctionnels avec le FT activé :