Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create Module bases-clavier-ordinateur-1.json (MODC-204) #11062

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

asilnomis
Copy link
Contributor

@asilnomis asilnomis commented Jan 10, 2025

🎄 Problème

Création du module 1ère marche "Les bases du clavier (sur un ordinateur) - 1"

🎁 Proposition

🧦 Remarques

🎅 Pour tester

https://app-pr11062.review.pix.fr/modules/bases-clavier-1/details

@asilnomis asilnomis requested a review from a team as a code owner January 10, 2025 10:36
@asilnomis asilnomis marked this pull request as draft January 10, 2025 10:37
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@asilnomis asilnomis changed the title [FEATURE] Create Module bases-clavier-ordinateur-1.json [FEATURE] Create Module bases-clavier-ordinateur-1.json (MODC-204) Jan 10, 2025
@PhilomeneChivard PhilomeneChivard marked this pull request as ready for review January 15, 2025 13:02
@PhilomeneChivard PhilomeneChivard marked this pull request as draft January 15, 2025 13:03
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Les tests Modulix ont échoué. Voici les détails :


> [email protected] modulix:test
> npm run test:api:path -- 'tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js' 'tests/devcomp/acceptance/module-instantiation_test.js' 'tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js'


> [email protected] test:api:path
> NODE_ENV=test mocha --exit --recursive --reporter=${MOCHA_REPORTER:-dot} tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js tests/devcomp/acceptance/module-instantiation_test.js tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js

(node:2042) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)


  ...!..........................................

  45 passing (9s)
  1 failing

  1) Unit | Infrastructure | Datasources | Learning Content | ModuleDatasource
       #list
         modules content
           module "bases-clavier-1" should contain a valid structure:
     AssertionError: 
============================================================


Chemin : grains[4].components[0].steps[1].elements[0].feedbacks.valid

Error(no-implicit-close): Element <p> is implicitly closed by document ending
https://html-validate.org/rules/no-implicit-close.html

Valeur concernée à rechercher :
<p><span class="feedback__state">Bonne réponse ! <span aria-hidden="true">🥒</span></p><p>Bravo ! Vous avez bien complété la phrase.</p>

────────────────────────────────────────────────────────────


Chemin : grains[4].components[0].steps[1].elements[0].feedbacks.valid

Error(close-order): Unclosed element '<span>'
https://html-validate.org/rules/close-order.html

Valeur concernée à rechercher :
<p><span class="feedback__state">Bonne réponse ! <span aria-hidden="true">🥒</span></p><p>Bravo ! Vous avez bien complété la phrase.</p>

────────────────────────────────────────────────────────────


Chemin : grains[4].components[0].steps[1].elements[0].feedbacks.valid

Error(close-order): End tag '</p>' seen but there were open elements
https://html-validate.org/rules/close-order.html

Valeur concernée à rechercher :
<p><span class="feedback__state">Bonne réponse ! <span aria-hidden="true">🥒</span></p><p>Bravo ! Vous avez bien complété la phrase.</p>

────────────────────────────────────────────────────────────


Chemin : grains[4].components[0].steps[1].elements[0].feedbacks.valid

Error(element-permitted-content): <p> element is not permitted as content under <span>
https://html-validate.org/rules/element-permitted-content.html

Valeur concernée à rechercher :
<p><span class="feedback__state">Bonne réponse ! <span aria-hidden="true">🥒</span></p><p>Bravo ! Vous avez bien complété la phrase.</p>

============================================================
: expected ValidationError: htmlvalidationerror { …(2) } to equal undefined
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js:46:33)



Copy link
Contributor

github-actions bot commented Feb 4, 2025

Les tests Modulix ont échoué. Voici les détails :


> [email protected] modulix:test
> npm run test:api:path -- 'tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js' 'tests/devcomp/acceptance/module-instantiation_test.js' 'tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js'


> [email protected] test:api:path
> NODE_ENV=test mocha --exit --recursive --reporter=${MOCHA_REPORTER:-dot} tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js tests/devcomp/acceptance/module-instantiation_test.js tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js

(node:2018) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)


  ...!..........................................

  45 passing (10s)
  1 failing

  1) Unit | Infrastructure | Datasources | Learning Content | ModuleDatasource
       #list
         modules content
           module "bases-clavier-1" should contain a valid structure:
     AssertionError: 
============================================================


Chemin : grains[4].components[0].steps[1].elements[0].feedbacks.invalid

Error(close-order): Stray end tag '</span>'
https://html-validate.org/rules/close-order.html

Valeur concernée à rechercher :
<p><span class="feedback__state">Mauvaise réponse.</span> <span aria-hidden="true">🍽️</span></span><br>Bien tenté ! Mais la phrase n’est pas identique. Réessayez !</p>

============================================================
: expected ValidationError: htmlvalidationerror { …(2) } to equal undefined
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js:46:33)



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants