-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Modifier l'appel Pix Orga qui récupère le status des CGU (PIX-15586) #10937
Merged
pix-service-auto-merge
merged 8 commits into
dev
from
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
Jan 8, 2025
Merged
[FEATURE] Modifier l'appel Pix Orga qui récupère le status des CGU (PIX-15586) #10937
pix-service-auto-merge
merged 8 commits into
dev
from
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lego-technix
added
👀 Tech Review Needed
👀 Func Review Needed
Need PO validation for this functionally
team-acces
labels
Jan 4, 2025
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
lego-technix
changed the title
Pix 15586 update prescription prescribers call to use new legal document versioning code
[FEATURE] Modifier l'appel Pix Orga qui récupère le status des CGU (PIX-15586)
Jan 4, 2025
lego-technix
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
from
January 6, 2025 07:03
cf1409a
to
51c372d
Compare
bpetetot
reviewed
Jan 6, 2025
P-Jeremy
reviewed
Jan 6, 2025
api/src/team/infrastructure/repositories/prescriber-repository.js
Outdated
Show resolved
Hide resolved
P-Jeremy
reviewed
Jan 6, 2025
api/src/team/infrastructure/repositories/prescriber-repository.js
Outdated
Show resolved
Hide resolved
EmmanuelleBonnemay
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
3 times, most recently
from
January 7, 2025 08:30
dee99ac
to
4ea4a63
Compare
bpetetot
reviewed
Jan 7, 2025
api/src/team/infrastructure/repositories/legal-document-api.repository.js
Outdated
Show resolved
Hide resolved
P-Jeremy
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
from
January 7, 2025 11:12
22b8859
to
4c785a6
Compare
EmmanuelleBonnemay
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
3 times, most recently
from
January 7, 2025 14:59
be009bf
to
f236898
Compare
bpetetot
approved these changes
Jan 8, 2025
lego-technix
commented
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Lu et testé fonctionnellement avec succès avec Firefox 🦊
Mais je ne peux pas mettre de coche car j'ai créé la PR.
EmmanuelleBonnemay
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
Need PO validation for this functionally
labels
Jan 8, 2025
pix-service-auto-merge
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
from
January 8, 2025 13:24
e5ca980
to
5636529
Compare
to be able to use the legalDocumentApiRepository in the prescriberRepository
…dency injection for usecases of team context to be able to use in usecases the prescriberRepository injected with the legalDocumentApiRepository
to be able to use in usecases the prescriberRepository injected with the legalDocumentApiRepository
…ed, pixCertifTermsOfServiceAccepted properties
pix-service-auto-merge
force-pushed
the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
from
January 8, 2025 13:41
5636529
to
cf9c7cf
Compare
pix-service-auto-merge
deleted the
pix-15586-update-prescription-prescribers-call-to-use-new-legal-document-versioning-code
branch
January 8, 2025 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Afin de mettre en place le versionement des CGU de Pix Orga, il est nécessaire de modifier l’API permettant de récupérer leur valeur afin de se baser sur le nouveau modèle.
🎁 Proposition
Sur l’appel
GET
/api/prescription/prescribers/{userId}
, récupérer les informations de CGU en se basant sur la nouvelle APIgetLegalDocumentStatusByUserId
du contexte legal-documents.🧦 Remarques
RAS
Nettoyage de propriétés liées aux CGU dans
/users/me
inutiliséesÀ priori, il semble que les données suivantes sont sérialisées dans l’appel
/users/me
mais jamais exploitées côté frontend (car/users/me
est utilisé uniquement dans Pix App). On les a donc supprimer du serialiseur de/users/me
:pixOrgaTermsOfServiceAccepted
pixCertifTermsOfServiceAccepted
🎅 Pour tester
FT_NEW_LEGAL_DOCUMENTS_VERSIONING=false
pix-15588-update-pix-orga-call-to-accept-TOS
de la PR [FEATURE] Modifier l’API permettant d’accepter les CGU afin de fonctionner avec le nouveau modèle (PIX-15588) #10894/users/me
inutilisées vérifier qu'on peut se connecter sans erreur à Pix App, Pix Certif et Pix Admin