feat(api): stop save userId / assessmentId in snapshots

1024pix · Feb 5, 2025 · a2c8317 · a2c8317
1 parent 4822cc2
commit a2c8317
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/...n/campaign-participation/infrastructure/repositories/campaign-participation-repository.js b/...n/campaign-participation/infrastructure/repositories/campaign-participation-repository.js
@@ -1,4 +1,4 @@
-import lodash from 'lodash';
+import pick from 'lodash/pick.js';
 
 import { knex } from '../../../../../db/knex-database-connection.js';
 import { constants } from '../../../../shared/domain/constants.js';
@@ -14,8 +14,6 @@ import { AvailableCampaignParticipation } from '../../domain/read-models/Availab
 
 const { TO_SHARE } = CampaignParticipationStatuses;
 
-const { pick } = lodash;
-
 const CAMPAIGN_PARTICIPATION_ATTRIBUTES = [
   'participantExternalId',
   'sharedAt',

diff --git a/...ipation/integration/infrastructure/repositories/campaign-participation-repository_test.js b/...ipation/integration/infrastructure/repositories/campaign-participation-repository_test.js
@@ -20,6 +20,7 @@ describe('Integration | Repository | Campaign Participation', function () {
   describe('#updateWithSnapshot', function () {
     let clock;
     let campaignParticipation;
+    let ke;
     const frozenTime = new Date('1987-09-01T00:00:00Z');
 
     beforeEach(async function () {
@@ -28,7 +29,7 @@ describe('Integration | Repository | Campaign Participation', function () {
         sharedAt: null,
       });
 
-      databaseBuilder.factory.buildKnowledgeElement({
+      ke = databaseBuilder.factory.buildKnowledgeElement({
         userId: campaignParticipation.userId,
         createdAt: new Date('1985-09-01T00:00:00Z'),
       });
@@ -75,8 +76,22 @@ describe('Integration | Repository | Campaign Participation', function () {
       });
 
       // then
-      const snapshotInDB = await knex.select('id').from('knowledge-element-snapshots');
+      const snapshotInDB = await knex.pluck('snapshot').from('knowledge-element-snapshots');
       expect(snapshotInDB).to.have.lengthOf(1);
+      expect(snapshotInDB).to.deep.equal([
+        [
+          {
+            id: ke.id,
+            answerId: ke.answerId,
+            competenceId: ke.competenceId,
+            createdAt: ke.createdAt.toISOString(),
+            earnedPix: 2,
+            skillId: ke.skillId,
+            source: ke.source,
+            status: ke.status,
+          },
+        ],
+      ]);
     });
 
     context('when there is a transaction', function () {